-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support k3s private registry configuration #114
Conversation
added .idea dir to .gitignore file
fix k3s's private-registry configuration not exist
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A great feature, thanks for submitting this. I have popped in some suggestions, mostly formatting but also a couple of questions. 🙂
@@ -10,3 +10,4 @@ __pycache__ | |||
ansible.cfg | |||
pyratlabs-issue-dump.txt | |||
.cache | |||
/.idea/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's this for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
work ide env is idea+OrchidE plugin, git clone and import to my workspace will auto create .idea
dir.
change code style
thanks for your patience. re-commit and push this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, cheers 👍 🍻
Support k3s private registry configuration
Support k3s private registry configuration
Issue type
Test instructions
Acceptance Criteria
Additional Information
vars.yml
Configuration in containerd can be used to connect to a private registry with a TLS connection and with registries that enable authentication as well.
will gen
/etc/rancher/k3s/registries.yaml
when you use containerd runtime.