Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support k3s private registry configuration #114

Merged
merged 4 commits into from
May 13, 2021

Conversation

anjia0532
Copy link
Contributor

Support k3s private registry configuration

Support k3s private registry configuration

Issue type

Test instructions

Acceptance Criteria

Additional Information

vars.yml

# ....
k3s_registries:
# rancher k3s doc https://rancher.com/docs/k3s/latest/en/installation/private-registry/
  mirrors:
#    docker.io:
#      endpoint:
#        - "https://mycustomreg.com:5000"
  configs:
#    "mycustomreg:5000":
#      auth:
#        username: xxxxxx # this is the registry username
#        password: xxxxxx # this is the registry password
#      tls:
#        cert_file: # path to the cert file used in the registry
#        key_file:  # path to the key file used in the registry
#        ca_file:   # path to the ca file used in the registry
# ....

Configuration in containerd can be used to connect to a private registry with a TLS connection and with registries that enable authentication as well.

will gen /etc/rancher/k3s/registries.yaml when you use containerd runtime.

Copy link
Member

@xanmanning xanmanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A great feature, thanks for submitting this. I have popped in some suggestions, mostly formatting but also a couple of questions. 🙂

@@ -10,3 +10,4 @@ __pycache__
ansible.cfg
pyratlabs-issue-dump.txt
.cache
/.idea/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's this for?

Copy link
Contributor Author

@anjia0532 anjia0532 May 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

work ide env is idea+OrchidE plugin, git clone and import to my workspace will auto create .idea dir.

README.md Outdated Show resolved Hide resolved
defaults/main.yml Outdated Show resolved Hide resolved
tasks/build/containerd/registries.yml Outdated Show resolved Hide resolved
tasks/build/containerd/registries.yml Outdated Show resolved Hide resolved
templates/registries.yaml.j2 Show resolved Hide resolved
tasks/state-installed.yml Show resolved Hide resolved
@xanmanning xanmanning self-assigned this May 8, 2021
@xanmanning xanmanning added the enhancement New feature or request label May 8, 2021
@anjia0532
Copy link
Contributor Author

thanks for your patience. re-commit and push this PR

Copy link
Member

@xanmanning xanmanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, cheers 👍 🍻

@xanmanning xanmanning merged commit 2b7fd37 into PyratLabs:main May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants