-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parmest utils submodule, added support for Params and Vars #2352
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2352 +/- ##
==========================================
+ Coverage 82.93% 85.66% +2.73%
==========================================
Files 612 621 +9
Lines 76023 76347 +324
==========================================
+ Hits 63049 65403 +2354
+ Misses 12974 10944 -2030
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@kaklise try merging main into your branch to see if that resolves the pypy failure |
…jective don't already exist
@kaklise just FYI, we're seeing these same test failures everywhere and working on a fix. |
Fixes #2281
Summary/Motivation:
This PR starts a utils submodule in parmest which contains functions that could be used within other Pyomo contrib packages. Currently, the submodule includes functionality from mpi-sppy (in
create_ef.py
andscenario_tree.py
), an mpi task manager (inmpi_utils.py
), and ipopt solver diagnostics (inipopy_solver_wrapper.py
). These files were all moved directly from the main parmest folder into parmest/utils.An an additional utility function was added to convert model Params to Vars. The function that converts Params to Vars builds on methods in PyROS. Some modifications were made to retain the names from theta list (indexed parameters create indexed variables, non indexed parameters create non indexed variables). The reactor design model was updated to define unknown parameters as Params. Tests include cases that use Param, IndexedParam, Var, and IndexedVar.
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: