Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-evaluate the need for NPV expression objects #1202

Closed
jsiirola opened this issue Nov 26, 2019 · 1 comment
Closed

Re-evaluate the need for NPV expression objects #1202

jsiirola opened this issue Nov 26, 2019 · 1 comment

Comments

@jsiirola
Copy link
Member

Recent work on how we generate standard repn (see #1073) seems to indicate that we may not need the NPV expression objects. Removing them would simplify not only expression generation and walking, but would make it easier for users creating their own expression visitors or solver interfaces.

We should document the edge cases that motivated the original introduction of NPV objects and then verify that new implementations of visitors / standard repn generation do not need the NPV objects. If that holds, then we can simplify the expression system.

@jsiirola
Copy link
Member Author

jsiirola commented May 8, 2020

Archived on the master Performance Proposals Issue (#1430). Closing this performance proposal until active development has begun.

@jsiirola jsiirola closed this as completed May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant