Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

define a new IPredicateInfo to mirror IDeriverInfo #2535

Closed
mmerickel opened this issue Apr 26, 2016 · 0 comments · Fixed by #3514
Closed

define a new IPredicateInfo to mirror IDeriverInfo #2535

mmerickel opened this issue Apr 26, 2016 · 0 comments · Fixed by #3514
Milestone

Comments

@mmerickel
Copy link
Member

One annoyance with predicates right now is that their signature is val, config which doesn't make much sense. It's not particularly good practice to pass around the config. The only reason it's done right now is because the containment predicate needs to call config.maybe_dotted. That's it. It'd be much preferred to be something like info, val which could more closely mirror the new IViewDeriverInfo. We could then define an IPredicateInfo which contained the registry and package information without passing the raw config.

This would be a backward compatibility issue, unfortunately, so I'd save it for Pyramid 2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant