-
Notifications
You must be signed in to change notification settings - Fork 211
Conversation
Hello @SkafteNicki! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-08-11 10:10:53 UTC |
Codecov Report
@@ Coverage Diff @@
## master #648 +/- ##
==========================================
- Coverage 88.41% 88.31% -0.11%
==========================================
Files 243 242 -1
Lines 13025 12922 -103
==========================================
- Hits 11516 11412 -104
- Misses 1509 1510 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's inherit the deprecated metrics from the targer TM metric and do simple arguments mapping, see what we have in PL v1.4
Referred to Lightning-AI/pytorch-lightning#6515 and PL v1.4.0 for the last few commits I pushed. Feel free to revert the change back if not needed :] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 😃
What does this PR do?
Deprecate
RougeMetric
andBleuScore
in favour of their counterparts introduced in version 0.5 of torchmetrics.Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃