This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 211
Add TabularForecaster task based on PyTorch Forecasting #647
Merged
ananyahjha93
merged 37 commits into
Lightning-Universe:master
from
sumanmichael:feature/pytorch_forecasting
Oct 29, 2021
Merged
Add TabularForecaster task based on PyTorch Forecasting #647
ananyahjha93
merged 37 commits into
Lightning-Universe:master
from
sumanmichael:feature/pytorch_forecasting
Oct 29, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #647 +/- ##
==========================================
- Coverage 89.01% 85.25% -3.77%
==========================================
Files 230 237 +7
Lines 12720 12884 +164
==========================================
- Hits 11323 10984 -339
- Misses 1397 1900 +503
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
sumanmichael
requested review from
Borda,
carmocca,
edenlightning,
ethanwharris,
justusschock,
kaushikb11 and
tchaton
as code owners
August 10, 2021 10:56
…nmichael/lightning-flash into feature/pytorch_forecasting
ethanwharris
changed the title
Adding tabular/forecasting
Add TabularForecaster task based on PyTorch Forecasting
Oct 28, 2021
Borda
approved these changes
Oct 29, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is huge, from top level screening it looks good :]
flash_examples/integrations/pytorch_forecasting/tabular_forecasting_interpretable.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: Jirka Borovec <[email protected]>
ananyahjha93
approved these changes
Oct 29, 2021
This was referenced Oct 29, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Integrating https://github.com/jdb78/pytorch-forecasting into tabular/forecasting
Fixes #528 #529 #530 #531 #532
Before submitting
Documentation to come in a follow-up
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃