-
Notifications
You must be signed in to change notification settings - Fork 211
Face Detection Task (task-a-thon) #606
Face Detection Task (task-a-thon) #606
Conversation
Hello @borhanMorphy! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-07-20 09:39:33 UTC |
Codecov Report
@@ Coverage Diff @@
## master #606 +/- ##
==========================================
- Coverage 89.05% 89.00% -0.06%
==========================================
Files 219 224 +5
Lines 11916 12111 +195
==========================================
+ Hits 10612 10779 +167
- Misses 1304 1332 +28
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@borhanMorphy Awesome work so far, looks really cool!!! I've left a few comments, mostly around moving preprocessing / postprocessing out of the model and also enabling from_datasets
rather than using from_data_source
directly.
334763f
to
13f0c27
Compare
…hy/lightning-flash into feature/face_detection
for more information, see https://pre-commit.ci
…phy/lightning-flash into feature/face_detection
for more information, see https://pre-commit.ci
…phy/lightning-flash into feature/face_detection
What does this PR do?
Fixes # (#503 #504 #505 #506 #507 #508)
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃