This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Serve sanity checks #423
Merged
Serve sanity checks #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanwharris
requested review from
Borda,
carmocca,
justusschock,
kaushikb11 and
tchaton
as code owners
Codecov Report
@@ Coverage Diff @@
## master #423 +/- ##
==========================================
+ Coverage 89.97% 91.31% +1.34%
==========================================
Files 112 112
Lines 7003 7060 +57
==========================================
+ Hits 6301 6447 +146
+ Misses 702 613 -89
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Borda
reviewed
Jun 17, 2021
Borda
reviewed
Jun 17, 2021
| @@ -115,7 +120,8 @@ jobs: | |||
|
|
|||
| - name: Tests | |||
| env: | |||
| FIFTYONE_DO_NOT_TRACK: true | |||
| FLASH_TEST_TOPIC: ${{ matrix.topic }} | |||
| FIFTYONE_DO_NOT_TRACK: true | |||
There was a problem hiding this comment.
Not sure if it can be. This was done by the fiftyone people for something on their end. I wouldn't want to change it in case something breaks.
Borda
reviewed
Jun 17, 2021
Borda
reviewed
Jun 17, 2021
flash/core/model.py
Outdated
| comp = FlashServeModelComponent(self) | ||
| composition = Composition(predict=comp) | ||
| composition = Composition(predict=comp, TESTING=os.environ["FLASH_TESTING"] == "1") |
There was a problem hiding this comment.
yep, some variables are 0/1 other you write s true... lets be consistent
tchaton
approved these changes
Jun 18, 2021
Co-authored-by: thomas chaton <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes # (issue)
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃