This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #37 +/- ##
==========================================
- Coverage 81.17% 80.91% -0.27%
==========================================
Files 32 46 +14
Lines 1036 1383 +347
==========================================
+ Hits 841 1119 +278
- Misses 195 264 +69
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Hello @SeanNaren! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-02-02 14:18:05 UTC |
SeanNaren
force-pushed
the
feature/seq2seq
branch
from
February 1, 2021 18:09
f190209
to
495b812
Compare
carmocca
reviewed
Feb 1, 2021
Co-authored-by: Carlos Mocholí <[email protected]>
SeanNaren
force-pushed
the
feature/seq2seq
branch
from
February 1, 2021 19:16
ba2cbb7
to
8d9775f
Compare
SeanNaren
requested review from
edenlightning,
tchaton and
teddykoker
as code owners
February 1, 2021 19:29
carmocca
approved these changes
Feb 1, 2021
tchaton
reviewed
Feb 1, 2021
Borda
reviewed
Feb 2, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is flash_notebooks/.lock
for?
why the strange notebook changes?
tchaton
approved these changes
Feb 2, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add Translation/Summarization and general Seq2Seq Task. This is a first pass, and will need more iteration in the future:
Painpoints:
Left to do: