-
Notifications
You must be signed in to change notification settings - Fork 211
Conversation
Codecov Report
@@ Coverage Diff @@
## master #272 +/- ##
==========================================
- Coverage 88.15% 88.11% -0.05%
==========================================
Files 74 74
Lines 3564 3567 +3
==========================================
+ Hits 3142 3143 +1
- Misses 422 424 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -37,80 +36,135 @@ def __init__(self, num_inputs, learning_rate=0.001, metrics=None): | |||
learning_rate=learning_rate, | |||
) | |||
|
|||
def training_step(self, batch: Any, batch_idx: int) -> Any: | |||
return super().training_step( | |||
(batch[DefaultDataKeys.INPUT], batch[DefaultDataKeys.TARGET]), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there any way that in the user api we can use directly with strings to make it more clean and avoid to import the data keys class ? to look something like:
(batch['input'], batch['target']),
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't really the user API though. This doc is for best practices to create a new Task, and that would be using the DefaultDataKeys
enum. Users of the tasks don't need to use the enum, but when creating new tasks they should be used.
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
What does this PR do?
Fixes # (issue)
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃