This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
timm integration #196
Merged
timm integration #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aniketmaurya
requested review from
Borda,
carmocca,
justusschock,
kaushikb11,
tchaton and
teddykoker
as code owners
Codecov Report
@@ Coverage Diff @@
## master #196 +/- ##
==========================================
- Coverage 85.70% 85.49% -0.22%
==========================================
Files 54 54
Lines 2483 2495 +12
==========================================
+ Hits 2128 2133 +5
- Misses 355 362 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Borda
reviewed
Mar 28, 2021
tchaton
reviewed
Mar 29, 2021
tchaton
reviewed
Mar 29, 2021
flash/vision/backbones.py
Outdated
| """ | ||
|
|
||
| if model_name in timm.list_models(): | ||
| backbone = timm.create_model(model_name, pretrained=pretrained, num_classes=0, |
There was a problem hiding this comment.
this method is suggested to create a model without a classification head in the timm docs. https://rwightman.github.io/pytorch-image-models/feature_extraction/#create-with-no-classifier-and-pooling
…lightning-flash into issue_172-add_timm
kaushikb11
approved these changes
Apr 6, 2021
carmocca
approved these changes
Apr 6, 2021
Borda
pushed a commit
that referenced
this pull request
Apr 17, 2021
Co-authored-by: Kaushik B <[email protected]> Co-authored-by: Kaushik Bokka <[email protected]> (cherry picked from commit 6e548a4)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #172
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃