This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 211
Support from_dicts
for Tabular Classification and Regression
#1331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krshrimali
requested review from
ethanwharris,
Borda,
tchaton,
justusschock,
carmocca and
kaushikb11
as code owners
May 6, 2022 10:56
krshrimali
force-pushed
the
tabular_classification/from_dict
branch
from
May 6, 2022 10:57
2be6d77
to
39f4c95
Compare
krshrimali
force-pushed
the
tabular_classification/from_dict
branch
from
May 6, 2022 11:19
19f5082
to
8787f63
Compare
for more information, see https://pre-commit.ci
ethanwharris
reviewed
May 6, 2022
ethanwharris
reviewed
May 6, 2022
Codecov Report
@@ Coverage Diff @@
## master #1331 +/- ##
==========================================
+ Coverage 89.86% 91.45% +1.59%
==========================================
Files 287 287
Lines 12900 12921 +21
==========================================
+ Hits 11592 11817 +225
+ Misses 1308 1104 -204
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
krshrimali
force-pushed
the
tabular_classification/from_dict
branch
from
May 9, 2022 05:21
def986a
to
a42c9de
Compare
krshrimali
changed the title
[WIP] Support
[WIP] Support May 9, 2022
from_dict
for Tabular Classification datasetfrom_dict
for Tabular Classification and Regression
krshrimali
changed the title
[WIP] Support
Support May 9, 2022
from_dict
for Tabular Classification and Regressionfrom_dict
for Tabular Classification and Regression
…Lightning/lightning-flash into tabular_classification/from_dict
krshrimali
commented
May 9, 2022
…Lightning/lightning-flash into tabular_classification/from_dict
krshrimali
commented
May 9, 2022
krshrimali
changed the title
Support
Support May 9, 2022
from_dict
for Tabular Classification and Regressionfrom_dicts
for Tabular Classification and Regression
ethanwharris
approved these changes
May 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 😃 Small suggestion
Co-authored-by: Ethan Harris <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Partially fixes #1326
from_dicts
method to load tabular data in the form of dictionaries.About the implementation:
DataFrame
and then call the method for loading a data frame input.Docs (for reviewers) artifacts: (note: I just pushed a commit to fix a minor typo, will update these links once CI is done uploading)
TabularClassificationData.from_dict
TabularRegressionData.from_dict
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃