Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Fix icevision default CLI #1306

Merged
merged 2 commits into from
Apr 22, 2022
Merged

Fix icevision default CLI #1306

merged 2 commits into from
Apr 22, 2022

Conversation

ethanwharris
Copy link
Collaborator

What does this PR do?

Fixes # (issue)

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@ethanwharris ethanwharris added bug / fix Something isn't working tests / CI Tests and continuous integration labels Apr 22, 2022
@ethanwharris ethanwharris added this to the 0.7.x milestone Apr 22, 2022
@codecov
Copy link

codecov bot commented Apr 22, 2022

Codecov Report

Merging #1306 (af12c53) into master (ed980a1) will increase coverage by 8.41%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1306      +/-   ##
==========================================
+ Coverage   83.34%   91.75%   +8.41%     
==========================================
  Files         287      287              
  Lines       12816    12816              
==========================================
+ Hits        10681    11759    +1078     
+ Misses       2135     1057    -1078     
Flag Coverage Δ
unittests 91.75% <100.00%> (+8.41%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/image/detection/cli.py 100.00% <100.00%> (+36.36%) ⬆️
flash/image/instance_segmentation/cli.py 100.00% <100.00%> (+41.17%) ⬆️
flash/image/keypoint_detection/cli.py 100.00% <100.00%> (+43.75%) ⬆️
flash/core/data/io/input_transform.py 70.49% <0.00%> (+0.26%) ⬆️
flash/core/data/data_module.py 94.16% <0.00%> (+0.41%) ⬆️
flash/core/data/utilities/classification.py 98.24% <0.00%> (+1.16%) ⬆️
flash/core/data/properties.py 90.62% <0.00%> (+1.56%) ⬆️
flash/core/data/transforms.py 96.49% <0.00%> (+1.75%) ⬆️
flash/image/segmentation/data.py 100.00% <0.00%> (+2.00%) ⬆️
flash/image/classification/data.py 97.87% <0.00%> (+2.83%) ⬆️
... and 49 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed980a1...af12c53. Read the comment docs.

@ethanwharris ethanwharris merged commit bd62406 into master Apr 22, 2022
@ethanwharris ethanwharris deleted the bugfix/icevision_cli branch April 22, 2022 18:23
krshrimali pushed a commit that referenced this pull request Apr 27, 2022
ethanwharris added a commit that referenced this pull request Apr 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug / fix Something isn't working tests / CI Tests and continuous integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant