Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Fix bug in number of tabular forecasting prediction samples #1149

Merged
merged 6 commits into from
Feb 4, 2022

Conversation

ethanwharris
Copy link
Collaborator

What does this PR do?

Fixes bug reported on slack

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Feb 1, 2022

Codecov Report

Merging #1149 (86b1712) into master (20b3a7d) will increase coverage by 0.36%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1149      +/-   ##
==========================================
+ Coverage   88.82%   89.18%   +0.36%     
==========================================
  Files         285      285              
  Lines       13007    13010       +3     
==========================================
+ Hits        11553    11603      +50     
+ Misses       1454     1407      -47     
Flag Coverage Δ
unittests 89.18% <ø> (+0.36%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/tabular/forecasting/input.py 97.05% <ø> (ø)
flash/core/serve/dag/order.py 96.76% <0.00%> (+0.01%) ⬆️
flash/core/serve/dag/rewrite.py 94.96% <0.00%> (+0.03%) ⬆️
flash/core/serve/dag/optimization.py 94.36% <0.00%> (+0.43%) ⬆️
flash/core/data/io/input.py 91.41% <0.00%> (+0.61%) ⬆️
flash/core/serve/interfaces/http.py 97.46% <0.00%> (+3.79%) ⬆️
flash/core/serve/interfaces/models.py 100.00% <0.00%> (+4.41%) ⬆️
flash/core/serve/_compat/cached_property.py 100.00% <0.00%> (+90.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20b3a7d...86b1712. Read the comment docs.

@ethanwharris ethanwharris added this to the v0.7 milestone Feb 4, 2022
@ethanwharris ethanwharris merged commit 8e4abf3 into master Feb 4, 2022
@ethanwharris ethanwharris deleted the bugfix/tabular_forecasting_predict_mode branch February 4, 2022 16:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug / fix Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant