Data Pipeline V2: Cleanup #1018
Conversation
tchaton
requested review from
ananyahjha93,
Borda,
carmocca,
ethanwharris,
justusschock and
kaushikb11
as code owners
| @@ -94,3 +98,11 @@ def num_features(self): | |||
| n_cls_val = getattr(self.val_dataset, "num_features", None) | |||
| n_cls_test = getattr(self.test_dataset, "num_features", None) | |||
| return n_cls_train or n_cls_val or n_cls_test | |||
|
|
|||
| from_folders = None | |||
There was a problem hiding this comment.
@ethanwharris Do we want to do this for now? Just an idea, but might not be worth it.
| @@ -407,3 +412,80 @@ def from_fiftyone( | |||
| ), | |||
| **data_module_kwargs, | |||
| ) | |||
|
|
|||
| @classmethod | |||
| def from_folders( | |||
There was a problem hiding this comment.
@ethanwharris Not sure about those.
Codecov Report
@@ Coverage Diff @@
## master #1018 +/- ##
==========================================
- Coverage 87.73% 81.69% -6.05%
==========================================
Files 254 254
Lines 13591 13655 +64
==========================================
- Hits 11924 11155 -769
- Misses 1667 2500 +833
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
LGTM, some small comments. @tchaton I think you will also need to update the instance segmentation and keypoint detection (maybe object detection too) examples that use the current from_folders method to use the from_icedata method instead.
| @@ -407,3 +412,80 @@ def from_fiftyone( | |||
| ), | |||
| **data_module_kwargs, | |||
| ) | |||
|
|
|||
| @classmethod | |||
| def from_folders( | |||
What does this PR do?
Fixes # (issue)
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃