Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Test Script(s) #66

Closed
FabianHofmann opened this issue May 6, 2020 · 2 comments
Closed

Add Test Script(s) #66

FabianHofmann opened this issue May 6, 2020 · 2 comments

Comments

@FabianHofmann
Copy link
Contributor

Since we're still having some trouble to properly intergrate v0.2 (#20), it would be helpful to add a test script which canvasses major relations.

Atm I'm trying to figure out how this would look like. Some things I have in mind:

  • Check coordinate alignment. As seen in Wrong coordinates and broken values in SARAH cutouts #62 coordinates are a sensitive thing, if they are wrong, you get nice twisted pictures. This is probably a small check that coordinates of all retrieved data and converted data are in increasing order.
  • Check shape of the cutout against the target shape, given by bounds and resolution
  • Check against occurrence of nan values. If you have nan values in your retrieved data (not converted) then something is wrong.

This list should continue. I'm starting to write down some test files. Feel free to add to the list

@euronion
Copy link
Collaborator

euronion commented May 6, 2020

I think running conversion checks with the different types of conversion functions should also be included, e.g. on a cutout (or fake cutout, i.e. providing a xarray.DataSet with the necessary variables hard coded and:

  • CFs with a predetermined PV panel
  • CFs with predetermined wind turbine
  • hydro ror generation time-series

and compare it against a reference.

These are the essential functions for atlite which I think make sense to have atleast included.

@FabianHofmann
Copy link
Contributor Author

Alright, perhaps a rough division into

  • test_cutout_creation.py
  • test_alignment.py
  • test_conversion.py

Probably the sparse array operations should also flow into a separate test.

  • test_sparse_operations.py

But let's see where we get...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants