Bump version to 0.3 #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it's ready now. |
termoshtt
approved these changes
Aug 22, 2018
src/lib.rs
Outdated
| //! It uses [pyo3](https://github.com/PyO3/pyo3) for rust bindings to cpython, and uses | ||
| //! [ndarray](https://github.com/bluss/ndarray) for rust side matrix library. | ||
| //! | ||
| //! For numpy dependency, it calls `import numpy.core` internally so you just need numpy |
There was a problem hiding this comment.
For numpy dependency, it calls import numpy.core internally. So you just need numpy
src/lib.rs
Outdated
| @@ -1,3 +1,35 @@ | |||
| //! `rust-numpy` provides Rust interfaces for [numpy](http://www.numpy.org/) APIs, | |||
There was a problem hiding this comment.
"numpy API" means Python API usually. This should be "NumPy C API".
https://docs.scipy.org/doc/numpy/reference/c-api.html
README.md
Outdated
| - [Latest release(can be broken)](https://docs.rs/numpy) | ||
| - [Current Master](https://rust-numpy.github.io/rust-numpy) | ||
|
|
||
|
|
||
| Dependencies |
README.md
Outdated
| Dependencies | ||
| ------------- | ||
| - nightly version of rust compiler (see [pyo3](https://github.com/PyO3/pyo3)) |
There was a problem hiding this comment.
nightly toolchain
and link for PyO3/pyo3#5 may be useful
README.md
Outdated
| - [rust-cpython](https://github.com/dgrunwald/rust-cpython) | ||
| **Note** | ||
| From 0.3, we migrated from rust-cpython to pyo3. | ||
| If you want rust-cpython, use version 0.2.1 from crates.io. |
There was a problem hiding this comment.
If you want to use rust-cpython
|
Thanks for review ❤️ |
|
Released 0.3.0 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO