emit c-string literals on Rust 1.77 or later #4269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidhewitt
reviewed
Jun 20, 2024
| LitCStr(LitCStr), | ||
| // There is currently no way to `concat!` c-string literals, we fallback to the `c_str!` macro in | ||
| // this case. | ||
| Tokens(TokenStream), |
There was a problem hiding this comment.
Agreed I think this case will have to stick around for the foreseeable future, but I think we would at least eventually be able to just use something like CStr::from_bytes_with_nul (which is const since 1.72).
There was a problem hiding this comment.
... or maybe #4270 is good enough for now :)
mejrs
reviewed
Jun 20, 2024
Co-authored-by: mejrs <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This emits c-string literals where possible when on Rust 1.77 or later.
Since we are not allowed to emit these literals on earlier Rust versions, we need to have the conditional compilation on the macro code itself, so I added a
build.rsto emit the requiredcfgs.We also have the case for
docattributes including macro invocations, since there is currently no way toconcat!c-string literals, this case falls back to thec_str!macroCloses #4261