Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try to debug codspeed issue #3627

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Conversation

davidhewitt
Copy link
Member

...

@davidhewitt davidhewitt added the CI-skip-changelog Skip checking changelog entry label Dec 4, 2023
@davidhewitt
Copy link
Member Author

Ok so I think I see what was going on, it looks like probably what was happening is that pip install was installing into the virtualenv and hitting PyO3/maturin#490

I'm not sure why this wasn't a problem initially. I wonder if it was a cache issue related to the same problems we were having recently with rustup conflicts.

I removed the pyo3_pytests/__init__.py to use a pure-rust maturin project, which should fix the problem. I also took the opportunity to refactor as per #3536

@davidhewitt davidhewitt marked this pull request as ready for review December 4, 2023 22:22
@davidhewitt
Copy link
Member Author

🎉 looks like that's fixed it. I'll merge this as I think there's nothing much to review here and it improves CI for the rest of the reviews.

@davidhewitt davidhewitt added this pull request to the merge queue Dec 4, 2023
Merged via the queue into PyO3:main with commit 93370d9 Dec 4, 2023
37 checks passed
@davidhewitt davidhewitt deleted the codspeed-fixup branch December 4, 2023 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-skip-changelog Skip checking changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant