Fix the #[macro_export] absolute path within the same crate issue
#2045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the crate-root `pyo3` item to ensure that our selected pyo3_path needs to be taken into account.
birkenfeld
force-pushed
the
pyo3_path
branch
2 times, most recently
from
6bd01c8
to
2d49dc3
Compare
|
Brilliant find, thanks very much! I'm going to close this one as the commit has been added into #2022 and is working nicely. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This takes care of https://github.com/PyO3/pyo3/runs/4455431379?check_suite_focus=true, reported in #2022 (comment) (cc @mejrs, @birkenfeld), by applying one of the workarounds suggested in rust-lang/rust#52234 (comment). Mainly the one where, because we are the only callers of the meta-macro, and because we are located in a non root-of-the-crate module, to append a
pub use macro_exported_macro;right after its definition, so that the fully qualified path ($crate::path::to::non_root_module::macro_exported_macro;) works even when within the crate where the export occurs 🙂