Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace bors-ng by self-hosted instance or switch to GH merge queues #3132

Closed
adamreichold opened this issue May 2, 2023 · 5 comments · Fixed by #3220
Closed

Replace bors-ng by self-hosted instance or switch to GH merge queues #3132

adamreichold opened this issue May 2, 2023 · 5 comments · Fixed by #3220
Labels
CI Continuous Integration github-actions Pull requests that update GitHub Actions code help-wanted

Comments

@adamreichold
Copy link
Member

As indicated by e.g. #3129 (comment), we need to switch to a self-hosted instance of bors-ng or use GitHub's built-in merge queues soon.

@adamreichold adamreichold added CI Continuous Integration help-wanted github-actions Pull requests that update GitHub Actions code labels May 2, 2023
@davidhewitt
Copy link
Member

Hmmm. It would be simpler for us to not maintain our own infra, so GitHub merge queues seem better to me?

Unfortunately, like bors, you only get a single merge method (e.g. merge, or squash). I asked if it could be changed, and GH saw it but doesn't seem to be in a rush to improve it https://github.com/orgs/community/discussions/46757#discussioncomment-5244498

From a quick Google I just found Mergify which has a free tier for open source, and allows configuration of the merge method per-PR; I wonder if that would be a nice alternative?

@adamreichold
Copy link
Member Author

Hmmm. It would be simpler for us to not maintain our own infra, so GitHub merge queues seem better to me?

Yes, stretched thin as we are, I think this is the path of least effort and we should take that for now. I am not even sure when someone will find the time to remove the bors-ng config and setup GH merge queues though...

@adamreichold
Copy link
Member Author

@davidhewitt I am not completely sure, but I think bors did delete the merged branches. Is that something we can enable for the GitHub merge queues as well?

@davidhewitt
Copy link
Member

@adamreichold
Copy link
Member Author

let's see what happens...

Seems to work, at least for #3252 it did.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration github-actions Pull requests that update GitHub Actions code help-wanted
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants