Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wheels for mixed Python/Rust project does not include Python source code #885

Open
1 of 2 tasks
padix-key opened this issue Apr 28, 2022 · 4 comments
Open
1 of 2 tasks
Labels
bug Something isn't working upstream Upstream issue

Comments

@padix-key
Copy link

padix-key commented Apr 28, 2022

Bug Description

Hi, I have a project (https://github.com/biotite-dev/fastpdb) built with maturin that uses mixed Rust/Python code.
However, the wheels built from this project do only include the .so file, the Python source file is not included.
This problem does not appear, when the package is installed from source distribution, via PEP 517 or via maturin develop.
This problem appears with maturin 0.12.14. A few months ago (2021-11-12) (I assume I used the newest version of maturin at this point) this issue did not occur.

Your Python version (python -V)

Python 3.9.9

Your pip version (pip -V)

21.3.1

What bindings you're using

No response

Does cargo build work?

  • Yes, it works

If on windows, have you checked that you aren't accidentally using unix path (those with the forward slash /)?

  • Yes

Steps to Reproduce

  1. maturin build --release -i python -o dist
  2. pip install dist/fastpdb-1.0.1-cp39-cp39-manylinux_2_24_x86_64.whl
@padix-key padix-key added the bug Something isn't working label Apr 28, 2022
@messense
Copy link
Member

We added support for excluding files from wheel by .gitignore file in #695, your gitignore file excluded .py file in https://github.com/biotite-dev/fastpdb/blob/c78b8d6a608693182ee0b9413bd3636d6b8f5e35/.gitignore#L54

@messense
Copy link
Member

Looks like the ignore crate we use behaves differently from git, see BurntSushi/ripgrep#1221.

@messense messense added the upstream Upstream issue label Apr 28, 2022
@padix-key
Copy link
Author

Thank you, removing the line in .gitignore solves the problem. Should I keep the issue open, until the upstream issue is fixed?

@messense
Copy link
Member

Should I keep the issue open, until the upstream issue is fixed?

Yes, let's keep it open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working upstream Upstream issue
Projects
None yet
Development

No branches or pull requests

2 participants