Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow skip wheel installation in maturin develop command #1651

Closed
messense opened this issue Jun 7, 2023 · 0 comments · Fixed by #1654
Closed

Allow skip wheel installation in maturin develop command #1651

messense opened this issue Jun 7, 2023 · 0 comments · Fixed by #1654
Labels
enhancement New feature or request

Comments

@messense
Copy link
Member

messense commented Jun 7, 2023

When using maturin together with Poetry in a monorepo, one can add Rust Python binding project as an editable module to Poetry dependencies, like

[tool.poetry.dependencies]
rust-project = { path = "rust-project", develop = true }

It works great with poetry install --sync, and for mixed Python/Rust project layout, when Python code changes there is no need to run poerty install again, it just works.

But when Rust code changes, poetry install --sync doesn't rebuild rust-project, so you have to use maturin develop instead, unfortunately while maturin develop makes the Rust code change visible, it causes poetry install --sync to rebuild rust-project again because Poetry thinks the dependency has been changed.

I think we can add an option to maturin develop command to skip wheel installation step, only build the extension module inplace, similar to #1419.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant