Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.12 support #1627

Closed
samuelcolvin opened this issue May 24, 2023 · 4 comments
Closed

3.12 support #1627

samuelcolvin opened this issue May 24, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@samuelcolvin
Copy link

samuelcolvin commented May 24, 2023

See pydantic/pydantic-core#629 It seems like trying to build for python 3.12 fails.

Miraculously our tests are passing, hence it would be good to build binaries so we can test the rest of pydantic.

Error output
📦 Including license file "/home/runner/work/pydantic-core/pydantic-core/LICENSE"
🍹 Building a mixed python/rust project
🔗 Found pyo3 bindings
💥 maturin failed
  Caused by: Failed to find a CPython 3.12 interpreter
Error: The process '/usr/bin/docker' failed with exit code 1
Error: The process '/usr/bin/docker' failed with exit code 1
    at ExecState._setResult (/home/runner/work/_actions/PyO3/maturin-action/v1/dist/index.js:1702:25)
    at ExecState.CheckComplete (/home/runner/work/_actions/PyO3/maturin-action/v1/dist/index.js:1685:18)
    at ChildProcess.<anonymous> (/home/runner/work/_actions/PyO3/maturin-action/v1/dist/index.js:1579:27)
    at ChildProcess.emit (node:events:527:28)
    at maybeClose (node:internal/child_process:1092:16)
    at Process.ChildProcess._handle.onexit (node:internal/child_process:302:5)
@samuelcolvin samuelcolvin added the enhancement New feature or request label May 24, 2023
@samuelcolvin
Copy link
Author

on reflection, I guess this should be moved to https://github.com/PyO3/maturin-action?

@messense
Copy link
Member

It's fine to leave it here, this requires quite some coordinations in different repositories.

@messense
Copy link
Member

messense commented May 26, 2023

Should be ready in next release.

Note that you also need to update python3-dll-a to latest version to fix Windows build.

@messense
Copy link
Member

Released in v1.0.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants