You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
So far the convention of prepending _ to highlight protected members is not used. While no operator requires the user to change anything after initialization and its use is limited to * (or matvec) and .H (or rmatvec), it may be better to be consistent with common practice.
Also, in some cases some variables are checked at initialization, it may more natural to convert those into @property. This is not just a pure stylistic change but may make better code (although will raise the bar for new developers?)
The text was updated successfully, but these errors were encountered:
Hi, we have done this for the key class, LinearOperator. I am not so convinced it makes sense to do it for every single operator… I suggest not to work on this (I keep it open until we are sure we don’t want to make this happen in the long run either…)
So far the convention of prepending
_
to highlight protected members is not used. While no operator requires the user to change anything after initialization and its use is limited to*
(ormatvec
) and.H
(orrmatvec
), it may be better to be consistent with common practice.Also, in some cases some variables are checked at initialization, it may more natural to convert those into
@property
. This is not just a pure stylistic change but may make better code (although will raise the bar for new developers?)The text was updated successfully, but these errors were encountered: