Catch usage of undefined name with global statement #324

seeeturtle · 2018-01-17T16:56:56Z

Related to #249

pyflakes/test/test_undefined_names.py

seeeturtle · 2018-01-17T18:43:28Z

@sigmavirus24 it seems the CI is failing not because of the test.
Can you look at it?

seeeturtle · 2018-01-17T18:47:31Z

ah. sorry, I didn't know that it's error of flake8
please ignore the above comment

seeeturtle · 2018-01-17T18:51:45Z

wait... all flake8 error isn't related with my PR.
it should be fixed.

adhikasp

Also please add the test from the original issue to make sure the problem is corrected.

def test(x):
    global x

adhikasp · 2018-01-18T02:48:07Z

pyflakes/checker.py

        elif isinstance(node.ctx, ast.Del):
            self.handleNodeDelete(node)
+            if (isinstance(self.scope, FunctionScope) and
+                    node.id in self.scope.global_names):
+                if not node.id in global_scope:


This line causing the CI to fail. E713, should be written if x not in y instead of if not x in y.

adhikasp · 2018-01-18T03:11:00Z

pyflakes/checker.py

            else:
                name = alias.asname or alias.name
-                importation = Importation(name, node, alias.name)
+                importation = Importation(name, node, name)


Are you sure about this? The 3rd arg of Importation originally always pass alias.name (the fullname of import) and now it could have value of alias.asname. The meaning of code changes.

oh, sorry. it's my mistake

adhikasp · 2018-01-18T03:15:22Z

pyflakes/checker.py

@@ -430,6 +431,13 @@ def unusedAssignments(self):
                    and isinstance(binding, Assignment)):
                yield name, binding

+    def usedAssignments(self):


Why is this declared but never used?

sorry. my mistake

myint · 2018-01-18T03:42:53Z

pyflakes/checker.py

@@ -1331,6 +1364,13 @@ def IMPORTFROM(self, node):
                                              module, alias.name)
            self.addBinding(node, importation)

+            if isinstance(self.scope, FunctionScope):


This code block is the same as the block above. It should probably be factored out into a separate function.

seeeturtle · 2018-01-18T13:29:34Z

Also please add the test from the original issue to make sure the problem is corrected.

@adhikasp, I've already added. check the commit message.

adhikasp · 2018-01-18T13:38:10Z

I've already added. check the commit message.

You mean this one? fdf2353#diff-44d7abf892e78127bd9438c51e1cfd49R340

But this is different compared to the snippet in the original issue. There should be another test when a function have args with same name as a global variable declared inside it. The function in your test above doesn't receive any argument.

seeeturtle · 2018-01-18T13:43:12Z

Sorry. I thought it was same code.

seeeturtle · 2018-01-18T13:46:56Z

@adhikasp By the way, What error should this test catch? UndefinedName?

seeeturtle · 2018-01-18T13:49:00Z

The issue is actually different with the given task at gci...

myint · 2018-01-18T14:05:55Z

Yeah, the GCI task I specified is different to #249. The one I specified matches the test case @seeeturtle created.

def main():
    global x
    print(x)

main()

So I think @adhikasp's comment about the test doesn't apply.

(Actually, #249 would have been easier. I probably should have specified that case for the GCI task.)

seeeturtle · 2018-01-18T14:07:55Z

@myint Can you approve the task too?

seeeturtle · 2018-01-18T14:09:33Z

Hooray! I didn't thought I can do this task well, but I did :)

adhikasp · 2018-01-18T14:11:51Z

Oh I see, my bad then 😄

seeeturtle · 2018-01-18T14:14:22Z

Just waiting for February now :) See you then

seeeturtle · 2018-07-15T15:11:26Z

Hello, @myint, I just found that this PR hasn't merged for a while.
Is there any problem?

myint · 2018-07-15T16:16:37Z

@seeeturtle One of the other PyCQA members needs to approve this before I can merge it. This is the case for several of the open pull requests.

seeeturtle · 2018-07-15T23:44:55Z

Ah, I got it. Thanks 2018. 7. 16. 오전 1:16 Steven Myint <[email protected]> 작성:

…

@seeeturtle One of the other PyCQA members needs to approve this before I can merge it. This is the case for several of the open pull requests. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

jayvdb

One fix required, and a few restructures.

Also please add a test

def f():
    global m
    print(m)

def g():
    global m
    m = 1

g()
f()

That should have no errors, and your patch handles this correctly. The added test will help prevent it breaking in the future, when other changes are made to pyflakes.

jayvdb · 2018-07-16T01:46:53Z

pyflakes/checker.py

            else:
                name = alias.asname or alias.name
                importation = Importation(name, node, alias.name)
            self.addBinding(node, importation)

+            self.store_global_scope(name, alias)


This needs to be self.store_global_scope(importation.name, alias) , otherwise the following will fail:

self.flakes(''' def f(): global foo; import foo.bar def g(): foo.is_used() ''')

You can add that test into test_assignedToGlobal.

Importing foo.bar is a bit strange -- it imports and binds the module foo as that name, and then imports foo.bar but there is no additional binding in the scope for foo.bar.

The determination of the binding name is done within SubmoduleImportation.

Note it would be much better if you did the self.store_global_scope(...) inside addBinding

Sorry for responding too late, @jayvdb.
I was reading the addBinding and there is something I can't understand.
Where does scope comes from? I can't find it...

Anyway, Thanks for reviewing :)

self-answering...

the variable in for loop (for controlling the loop) can be used at outside of it.

jayvdb · 2018-07-16T01:47:24Z

pyflakes/checker.py

            if '.' in alias.name and not alias.asname:
-                importation = SubmoduleImportation(alias.name, node)
+                importation = SubmoduleImportation(name, node)


this change can be reverted.

jayvdb · 2018-07-16T01:54:23Z

pyflakes/checker.py

        elif isinstance(node.ctx, ast.Del):
            self.handleNodeDelete(node)
+            if (isinstance(self.scope, FunctionScope) and


this should go in handleNodeDelete, where there is already logic regarding globals

jayvdb · 2018-07-16T01:55:17Z

pyflakes/checker.py

        elif isinstance(node.ctx, (ast.Store, ast.AugStore)):
            self.handleNodeStore(node)
+            if (isinstance(self.scope, FunctionScope) and


this should go in handleNodeStore, where there is already logic regarding globals

jayvdb · 2018-07-16T01:58:19Z

pyflakes/checker.py

        # Locate the name in locals / function / globals scopes.
        if isinstance(node.ctx, (ast.Load, ast.AugLoad)):
            self.handleNodeLoad(node)
            if (node.id == 'locals' and isinstance(self.scope, FunctionScope)
                    and isinstance(node.parent, ast.Call)):
                # we are doing locals() call in current scope
                self.scope.usesLocals = True
+            if (isinstance(self.scope, FunctionScope) and


this should probably go in handleNodeLoad

When we use undefined name declared by global statement, pyflakes should catch the error but it doesn't. This will fix pyflakes to catch this error. Note test_undefined_global for example of this.

seeeturtle · 2018-12-14T16:25:13Z

done @jayvdb

retnikt · 2020-04-28T13:51:45Z

Will this ever get merged? It's been two years!

janosh · 2021-10-14T15:11:55Z

Anything I can do to help push this over the finish line?

seeeturtle changed the title ~~Closes https://github.com/PyCQA/pyflakes/issues/249~~ Closes issues:249 Jan 17, 2018

sigmavirus24 reviewed Jan 17, 2018

View reviewed changes

pyflakes/test/test_undefined_names.py Outdated Show resolved Hide resolved

seeeturtle force-pushed the issue-249 branch 2 times, most recently from a9bdb17 to 869e6c0 Compare January 17, 2018 18:10

seeeturtle changed the title ~~Closes issues:249~~ Catch usage of undefined name with global statement Jan 17, 2018

seeeturtle force-pushed the issue-249 branch from 869e6c0 to fdf2353 Compare January 17, 2018 18:35

adhikasp reviewed Jan 18, 2018

View reviewed changes

myint requested changes Jan 18, 2018

View reviewed changes

seeeturtle force-pushed the issue-249 branch 2 times, most recently from 1bda547 to 4b00b8d Compare January 18, 2018 13:56

myint approved these changes Jan 18, 2018

View reviewed changes

adhikasp approved these changes Jan 18, 2018

View reviewed changes

jayvdb requested changes Jul 16, 2018

View reviewed changes

seeeturtle force-pushed the issue-249 branch from 4b00b8d to 72f208f Compare October 8, 2018 14:47

Catch usage of undefined name with global statement

6f7f425

When we use undefined name declared by global statement, pyflakes should catch the error but it doesn't. This will fix pyflakes to catch this error. Note test_undefined_global for example of this.

seeeturtle force-pushed the issue-249 branch from 72f208f to 6f7f425 Compare December 14, 2018 16:24

seeeturtle mentioned this pull request Feb 8, 2019

False positive: F401 'foo' imported but unused; when marking variable as global variable in a function #389

Open

Catch usage of undefined name with global statement #324

Are you sure you want to change the base?

Catch usage of undefined name with global statement #324

Conversation

seeeturtle commented Jan 17, 2018 • edited by jayvdb Loading

seeeturtle commented Jan 17, 2018

seeeturtle commented Jan 17, 2018 • edited Loading

seeeturtle commented Jan 17, 2018

adhikasp left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

seeeturtle commented Jan 18, 2018 • edited Loading

adhikasp commented Jan 18, 2018

seeeturtle commented Jan 18, 2018

seeeturtle commented Jan 18, 2018

seeeturtle commented Jan 18, 2018

myint commented Jan 18, 2018 • edited Loading

seeeturtle commented Jan 18, 2018

seeeturtle commented Jan 18, 2018

adhikasp commented Jan 18, 2018

seeeturtle commented Jan 18, 2018

seeeturtle commented Jul 15, 2018 • edited Loading

myint commented Jul 15, 2018

seeeturtle commented Jul 15, 2018 via email

jayvdb left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

seeeturtle Aug 4, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

seeeturtle commented Dec 14, 2018

retnikt commented Apr 28, 2020

janosh commented Oct 14, 2021

seeeturtle commented Jan 17, 2018 •

edited by jayvdb

Loading

seeeturtle commented Jan 17, 2018 •

edited

Loading

seeeturtle commented Jan 18, 2018 •

edited

Loading

myint commented Jan 18, 2018 •

edited

Loading

seeeturtle commented Jul 15, 2018 •

edited

Loading

seeeturtle Aug 4, 2018 •

edited

Loading