Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

6.3.0: incorrect version in pyproject.toml?🤔 #647

Open
wuch-g2v opened this issue Jul 4, 2023 · 2 comments
Open

6.3.0: incorrect version in pyproject.toml?🤔 #647

wuch-g2v opened this issue Jul 4, 2023 · 2 comments

Comments

@wuch-g2v
Copy link

wuch-g2v commented Jul 4, 2023

Looks like version in pyproject.toml is incorrect.

version = "0.0.0-dev"

@tjanez
Copy link
Contributor

tjanez commented Jul 5, 2023

When I was updating the Fedora package recently, I also encountered this.

As far as I can see, the version is only set dynamically when building a release with GitHub Actions:

- name: Bump version number
run: poetry version ${{ github.event.release.tag_name }}

It is set to the tag name which invoked the build.

This is not very practical for the downstream rebuilds. E.g., in Fedora RPM package, I needed to implement this work-around:

sed -r -i 's/(version = ")0.0.0-dev/\1%{version}/' pyproject.toml

@wuch-g2v
Copy link
Author

wuch-g2v commented Jul 5, 2023

Why not use poetry-dynamic-versioning? 🤔

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants