B015: prepend "assert" and fix verb tense #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
stevepiercy
commented
Nov 29, 2020
stevepiercy
commented
- See B015 Pointless comparison advice is not complete #149
cooperlees
approved these changes
Nov 29, 2020
| @@ -118,7 +118,7 @@ instead of ``except (SomeError,):``. | |||
| Write ``except Exception:``, which catches exactly the same exceptions. | |||
|
|
|||
| **B015**: Pointless comparison. This comparison does nothing but | |||
| wastes CPU instructions. Remove it. | |||
| waste CPU instructions. Either prepend ``assert`` or remove it. | |||
There was a problem hiding this comment.
FWIW, assert could possibly not always technically be the right thing too ...
This was referenced Mar 9, 2021
This was referenced Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.