Skip to content
This repository has been archived by the owner on Sep 20, 2020. It is now read-only.

Refactor router.js:server/routes/router.js #27

Open
Purukitto opened this issue Aug 28, 2019 · 2 comments
Open

Refactor router.js:server/routes/router.js #27

Purukitto opened this issue Aug 28, 2019 · 2 comments
Labels
begginer Good to get started with contributing to Yuso feature_request good first issue Good for newcomers low-priority Things that aren't breaking the application; Work on this if you have a short break

Comments

@Purukitto
Copy link
Owner

I've selected router.js:server/routes/router.js for refactoring, which is a unit of 49 lines of code. Addressing this will make our codebase more maintainable and improve Better Code Hub's Write Short Units of Code guideline rating! 👍

Here's the gist of this guideline:

  • Definition 📖
    Limit the length of code units to 15 lines of code.
  • Why
    Small units are easier to analyse, test and reuse.
  • How 🔧
    When writing new units, don't let them grow above 15 lines of code. When a unit grows beyond this, split it in smaller units of no longer than 15 lines.

You can find more info about this guideline in Building Maintainable Software. 📖


ℹ️ To know how many other refactoring candidates need addressing to get a guideline compliant, select some by clicking on the 🔲 next to them. The risk profile below the candidates signals (✅) when it's enough! 🏁


Good luck and happy coding! :shipit: ✨ 💯

@Purukitto Purukitto added good first issue Good for newcomers low-priority Things that aren't breaking the application; Work on this if you have a short break begginer Good to get started with contributing to Yuso labels Aug 28, 2019
@issue-label-bot

This comment has been minimized.

@mashuDuek
Copy link

mashuDuek commented Aug 30, 2019

Opened PR - #32

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
begginer Good to get started with contributing to Yuso feature_request good first issue Good for newcomers low-priority Things that aren't breaking the application; Work on this if you have a short break
Projects
None yet
Development

No branches or pull requests

2 participants