Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra layer banner cannot be copied in crafting table #71

Open
4 tasks done
PainOchoco opened this issue Apr 9, 2024 · 1 comment
Open
4 tasks done

Extra layer banner cannot be copied in crafting table #71

PainOchoco opened this issue Apr 9, 2024 · 1 comment

Comments

@PainOchoco
Copy link

Spark link

Expected behavior

I expect banners with extra layers to be duplicated with the copying crafting recipe. https://minecraft.wiki/w/Banner#Copying

Observed/Actual behavior

No crafting output is produced when trying to use the copying crafting recipe on a banner with extra layer.

Steps/models to reproduce

  1. Set PurpurExtras config.yml : settings.loom.max-layers: >6 (e.g. 10)
  2. Run a server with Purpur and PurpurExtras
  3. Craft a banner with more than 6 layers
  4. Into a crafting table or survival crafting slots, put the extra layer banner and a blank banner of the same color (copy recipe) in the crafting grid.
  5. Notice there is no output

PurpurExtras version

[01:26:32 INFO]: PurpurExtras version 1.30.0

Agreements

  • I am running the latest version of PurpurExtras available to download from modrinth.com/plugin/purpurextras/versions.
  • I have searched for and ensured there isn't already an open issue regarding this.
  • My version of Minecraft is supported by PurpurExtras.
  • I am using the latest or recommended version of Purpur available from purpurmc.org/downloads.

Other

No response

@GroleDev
Copy link

GroleDev commented Apr 10, 2024

Spark link

Expected behavior

I expect banners with extra layers to not lose the first layers applied when I apply a new one in loom.

Observed/Actual behavior

Once five layers are applied, when you try to apply a new one (even the sixth one that Minecraft normally accept) and put the result in the loom editing slot, the layers already applied start to disapear looking like they are replaced by the new one.

It will be fixed if you move the banner in your inventory or duplicate it while in creative, but if you press echap and quit the UI with the banner on the loom editing slot the banner will not have it layers back.

Steps/models to reproduce

  1. Set PurpurExtras config.yml : settings.loom.max-layers: >6 (e.g. 10)
  2. Run a server with Purpur and PurpurExtras
  3. Craft a banner with 5 layers
  4. Into a loom, add a 6th layer on the banner
  5. Put the banner on the loom editing slot
  6. Notice that the banner have it first layer removed
  7. Quit the UI
  8. Notice that the banner in you inventory have lost it first layer

PurpurExtras version

[01:26:32 INFO]: PurpurExtras version 1.30.0

Agreements

  • I am running the latest version of PurpurExtras available to download from modrinth.com/plugin/purpurextras/versions.
  • I have searched for and ensured there isn't already an open issue regarding this.
  • My version of Minecraft is supported by PurpurExtras.
  • I am using the latest or recommended version of Purpur available from purpurmc.org/downloads.

Other

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants