Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Third party notices #86

Open
aguzev opened this issue May 9, 2023 · 1 comment
Open

Third party notices #86

aguzev opened this issue May 9, 2023 · 1 comment
Assignees
Labels
documentation Improvements or additions to documentation fixed Issue is fixed in current or future version Retest Retest fix

Comments

@aguzev
Copy link
Collaborator

aguzev commented May 9, 2023

Toolkit contains two DLLs supplied by Microsoft under MIT license. Does it require a notice in the source code or module descriptions?

@aguzev aguzev added documentation Improvements or additions to documentation question Further information is requested labels May 9, 2023
@mikenelson-io
Copy link
Member

Yes, we need to include the MIT license. We can add it as part of the comment headers of the module or as a separate file. I would suggest adding it as a separate file as we do with the SDKv2. If we add it as a file, we need to note in the module comment headers what DLL references that license.

@aguzev aguzev added working on it Actively being worked on or planned for next release and removed question Further information is requested labels May 17, 2023
@aguzev aguzev self-assigned this May 17, 2023
@aguzev aguzev mentioned this issue May 19, 2023
@aguzev aguzev added fixed Issue is fixed in current or future version Retest Retest fix and removed working on it Actively being worked on or planned for next release labels May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation fixed Issue is fixed in current or future version Retest Retest fix
Projects
None yet
Development

No branches or pull requests

3 participants