switching to macro substitution for prebid version #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just noticed that merged, what I would encourage you to do for safety, is to submit a pr for using the storage manager that is clean [very narrowly scoped] and you won't see any disruption as release is not until next week. |
|
@pnhegde and @tej656 , please review this when you can. This implements the necessary extra communication method for sending beacons in prebid, see conversation here: prebid#11838 Let me know when you can review this so we can put it to the prebid team and have the sendBeacon code available for the rest of the module providers, pending external review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latest review actions in response to Patrick M's review
FYI, they have already merged a change to modify the existing master codes mechanism for working with local storage:
prebid#11830
This is part 1 of the solution to update the prebid PR for the analytics adapter
The second part will be to fix the conflicts