Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confirm that use of BLAST's -max_target_seqs is intentional #1

Open
armish opened this issue Sep 29, 2018 · 1 comment
Open

Confirm that use of BLAST's -max_target_seqs is intentional #1

armish opened this issue Sep 29, 2018 · 1 comment

Comments

@armish
Copy link

armish commented Sep 29, 2018

Hi there,

This is a semi-automated message from a fellow bioinformatician. Through a GitHub search, I found that the following source files make use of BLAST's -max_target_seqs parameter:

Based on the recently published report, Misunderstood parameter of NCBI BLAST impacts the correctness of bioinformatics workflows, there is a strong chance that this parameter is misused in your repository.

If the use of this parameter was intentional, please feel free to ignore and close this issue but I would highly recommend to add a comment to your source code to notify others about this use case. If this is a duplicate issue, please accept my apologies for the redundancy as this simple automation is not smart enough to identify such issues.

Thank you!
-- Arman (armish/blast-patrol)

@dfornika
Copy link
Member

Thanks for raising this issue. I do need to take a closer look at how I'm using that parameter. I had been assuming that setting it to -max_target_seqs 1 would return the one 'best hit'. After reading the paper you linked to I realize that isn't the case, so I will need to adjust my script to account for this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants