Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependence on speech_recognition for Wit #268

Closed
qmac opened this issue Mar 1, 2018 · 3 comments
Closed

Remove dependence on speech_recognition for Wit #268

qmac opened this issue Mar 1, 2018 · 3 comments

Comments

@qmac
Copy link
Collaborator

qmac commented Mar 1, 2018

Although speech_recognition was initially very useful, its somewhat unnecessary now that the Wit API is the only converter using it. In addition, its stuck using a 2016 version of the API.

@tyarkoni
Copy link
Collaborator

tyarkoni commented Mar 2, 2018

Alternatively, we could leave it in and add a generic SpeechRecognitionAPIConverter class if that's possible given the speech_recognition architecture.

@qmac
Copy link
Collaborator Author

qmac commented Mar 28, 2018

Hesitant to close this issue because I still don't love being stuck at the 2016 version of the API. I have a sneaking suspicion this is causing the occasional "Bad request" errors on Wit tests.

@qmac
Copy link
Collaborator Author

qmac commented Jun 28, 2018

Closing for now, hopefully speech_recognition gets updated soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants