Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try introducing Typescript #1

Open
Psigio opened this issue Mar 6, 2018 · 2 comments
Open

Try introducing Typescript #1

Psigio opened this issue Mar 6, 2018 · 2 comments
Assignees
@Psigio
Labels
wip

Comments

@Psigio
Copy link
Owner

Psigio commented Mar 6, 2018

No description provided.

@Psigio Psigio added the wip label Mar 6, 2018
@Psigio Psigio self-assigned this Mar 6, 2018
@Psigio
Copy link
Owner Author

Psigio commented Mar 6, 2018

Initial conversion of files from Flow on 8ce8b03

@Psigio
Copy link
Owner Author

Psigio commented Mar 6, 2018 •
edited
Loading

Due to an issue reported on rollup-plugin-typescript (#43) - moved to https://github.com/ezolenko/rollup-plugin-typescript2 - this seems to work correctly in that typescript errors cause the build to fail.

See 450b48f - need to understand why it's necessary to specify named exports for d3 files in rollup commonjs plugin now, possible some interaction with the generated JS files from TS.

Repository owner locked and limited conversation to collaborators Mar 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Psigio Psigio

Labels
wip
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Psigio