Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Artifacts with methods to old smart contracts #255

Closed
tafonina opened this issue Feb 18, 2022 · 1 comment · Fixed by sprotest/proxeus-core#18
Closed

Artifacts with methods to old smart contracts #255

tafonina opened this issue Feb 18, 2022 · 1 comment · Fixed by sprotest/proxeus-core#18
Assignees
Labels
tokens Issues that involve web3 or Solidity

Comments

@tafonina
Copy link
Contributor

tafonina commented Feb 18, 2022

Subject of the issue

In the code there are calls to old or nonexistent methods of smart contracts:
example file ui/wallet/src/ProxeusEthereum/services/ProxeusFS.js

line 8

async XESAmountPerFile ({ providers }) {
    return this.contract.methods.getXESPrice().call()
  }

line 25

fileHasSP (hash, spAddress) {
    return this.contract.methods.fileHasSP(hash, spAddress).call()
  }
  • getXESPrice doesnt exist in ProxeusFS contract
  • fileHasSP exists only in old contract (repo storage-app)

Solution

check is ProxeusFS service is used, get rid of artifacts check other cases of unused contract methods:
The actual list of ProxeusFS smart contract methods:

  • registerFile
  • verifyFile
  • signFile
  • getFileSigners
@tafonina tafonina changed the title Artifacts with methods to old contracts Artifacts with methods to old smart contracts Feb 18, 2022
@loleg loleg added bug Something isn't working tokens Issues that involve web3 or Solidity and removed bug Something isn't working labels Apr 29, 2022
@loleg loleg moved this to Todo in Maintenance - Q1 2024 Aug 11, 2023
@loleg loleg moved this from Todo to In Progress in Maintenance - Q1 2024 Aug 11, 2023
@Kamel-83 Kamel-83 assigned slavas490 and unassigned tafonina Oct 13, 2023
@slavas490 slavas490 moved this from In Progress to In testing in Maintenance - Q1 2024 Oct 24, 2023
@github-project-automation github-project-automation bot moved this from In testing to Done in Maintenance - Q1 2024 Oct 24, 2023
@Kamel-83 Kamel-83 moved this from Done to In Progress in Maintenance - Q1 2024 Oct 27, 2023
@tafonina tafonina moved this from In Progress to In testing in Maintenance - Q1 2024 Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tokens Issues that involve web3 or Solidity
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants