Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Failure on tvOS #1903

Closed
IndyShepherd opened this issue Apr 6, 2022 · 5 comments
Closed

Build Failure on tvOS #1903

IndyShepherd opened this issue Apr 6, 2022 · 5 comments
Assignees
Labels
bug something broken that needs fixing, confirmed and reproduceable

Comments

@IndyShepherd
Copy link

Hello,
I continue to receive the same build failure error message when almost complete.

Showing All Errors Only -> Compile Swift source files (arm64)
/Users/patrickfisk/Provenance/Provenance/Emulator/CoreOptionsViewController.swift:126:108:
'sheetPresentationController' is unavailable in tvOS'
'sheetPresentationController' has been explicitly marked unavailable here

I am installing from MacBook Monterey. I have xCode 13.3. I have downloaded the latest Source Code for Provenance. I am Choosing ProvenanceTV-Release > myAppleTV. (tvOS 15.4)

Expected:

Expecting the Build to complete Successfully

Actual:

The Build fails with error message above

Reproduce:

  1. Build Provenance from Source
  2. Setup Provenance Workspace
  3. ProvenanceTV-Release -> AppleTV (tvOS 15.4)

NOTES

APP VERSION

APP SOURCE

INSTALLED BY

PLATFORM

iOS/tvOS VERSION


🚫 We DO NOT support unofficial builds installed from 3rd-party sites. (Official Install)
Need help or have a suggestion? Join our Official Discord

@IndyShepherd IndyShepherd added the bug something broken that needs fixing, confirmed and reproduceable label Apr 6, 2022
@IndyShepherd
Copy link
Author

As information - I found the file where that was being called: CoreOptionsViewController

if #available(iOS 15.0, *), let sheetPresentationController = actionController.sheetPresentationController {

// I changed it to this:

if #available(iOS 15.0, *), let sheetPresentationController = actionController.popoverPresentationController {


The Build is working fine now! (tvOS 15.4)

@JoeMatt
Copy link
Member

JoeMatt commented Apr 11, 2022

if #available(iOS 15.0, *), let sheetPresentationController

this should be fixed already on develop,

                            if #available(iOS 15.0, *), let sheetPresentationController = actionController.sheetPresentationController {
//                                let cellRect = self.tableView.rectForRow(at: IndexPath(row: rowIndex, section: sectionIndex))
                                sheetPresentationController.sourceView = self.tableView
//                                sheetPresentationController.sourceRect = cellRect
                            } else if let popoverPresentationController = actionController.popoverPresentationController {
                                let cellRect = self.tableView.rectForRow(at: IndexPath(row: rowIndex, section: sectionIndex))
                                popoverPresentationController.sourceView = self.tableView
                                popoverPresentationController.sourceRect = cellRect
                             }
                             ```

@JoeMatt JoeMatt self-assigned this Apr 11, 2022
@JoeMatt
Copy link
Member

JoeMatt commented Apr 11, 2022

nevermind, this is broken on current xcode for me still as well. It was working before...

@JoeMatt
Copy link
Member

JoeMatt commented Apr 11, 2022

fixed and pushed to develop

@IndyShepherd
Copy link
Author

Thank youI. I appreciate your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken that needs fixing, confirmed and reproduceable
Projects
None yet
Development

No branches or pull requests

2 participants