Fix futures #28469
Open
Fix futures #28469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, fix the span for function inputs.
This way we don't get misleading error messages.
mikebenfield
force-pushed
the
fix-futures
branch
from
2760c4c to
8df853f
Compare
d0cd
reviewed
Dec 4, 2024
Cargo.lock
Outdated
There was a problem hiding this comment.
Should we update the lockfile? One implication of doing this often is that the CI caches are invalidated every time the lockfile changes.
| } | ||
|
|
||
| let ty: Type = if is_future { | ||
| inferred_type.expect("Type checking guarantees the inferred type is present") |
There was a problem hiding this comment.
Nit. Could we use the unreachable macro here? This helps us look back on those sorts of invariants.
mikebenfield
force-pushed
the
fix-futures
branch
from
8df853f to
2f8b4f4
Compare
|
Indeed, this issue is now fixed (and I've updated the last commit message to refer to it). And I think this one is too. Maybe. The compiler will now give an error for the code in the example, because you can't assign a Future out of a tuple to a new variable like that. I think that suffices to fix this issue, but maybe there is still a problem around type checking futures? |
Now futures are tracked properly, whether they're stored directly in a variable or in a tuple. Also, error if a future is used improperly. Fixes #28471
mikebenfield
force-pushed
the
fix-futures
branch
from
2f8b4f4 to
12ea37e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.