fix: Header parser (naive) #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameshoulahan
force-pushed
the
fix/header-parser
branch
from
fa0fc36
to
35d9c83
Compare
The new header parser did not correctly deal with two edge cases: 1. The message contains an embedded RFC822 message with no header 2. Parsing something (not necessarily a header) with a key but no value This fix checks that what we think is a header actually is one in a naive way by trying to parse it and seeing if it returns an error. It also handles the case that a header key was not finished being read by returning an error, indicating this wasn't a valid header).
jameshoulahan
force-pushed
the
fix/header-parser
branch
from
35d9c83
to
ddabc1a
Compare
LBeernaertProton
approved these changes
Sep 19, 2022
|
🎉 This PR is included in version 0.12.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new header parser did not correctly deal with two edge cases:
This fix checks that what we think is a header actually is one in a naive way by trying to parse it and seeing if it returns an error. It also handles the case that a header key was not finished being read by returning an error, indicating this wasn't a valid header).