Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request]Need Official Typescript support #952

Closed
lwyj123 opened this issue Jul 16, 2019 · 8 comments
Closed

[feature request]Need Official Typescript support #952

lwyj123 opened this issue Jul 16, 2019 · 8 comments

Comments

@lwyj123
Copy link

lwyj123 commented Jul 16, 2019

Issue details

Maybe we need to do something for the trend of Typescript. Now most of my code is written using typescript, But the prosemirror's types support is not complete.

@marijnh
Copy link
Member

marijnh commented Jul 16, 2019

I'm sympathetic to that, and eventually it'd be nice to port ProseMirror to TypeScript entirely. (It started as typed code, but at the time neither Flow nor TypeScript were mature enough to warrant the extra friction—but by now TypeScript has come a long way, and using it in CodeMirror 6 has been a great experience.)

However, I don't see myself having time to do this in the near future, and it'd involve finnicky stuff like porting over our documentation generation to another approach.

So for now, I recommend continuing to submit fixes to the types provided by definitelytyped when you notice problems.

@lcswillems
Copy link

lcswillems commented Nov 14, 2019

I don't know if you heard about it but with the latest version of TypeScript (3.7), the --declaration and --allowJs flags can be used together (microsoft/TypeScript#7546). It means that typings can be directly generated from JS code. It might help in your case?

Moreover, a JS codebase can be progressively moved to a TypeScript one, i.e. some files can be first transformed into TypeScript ones, then some other later, and so on...

@ftomassetti
Copy link

Checking if the plans have been updated 2 years after

@PowerKiKi
Copy link

Most packages have been ported to Typescript, except prosemirror-tables. Is there any specific reason for that ?

@marijnh was it only a lack of time ? is there a way to help migrate this last package ?

@ocavue as the most recent maintainer of the package, do you have any opinion on the situation ?

@ocavue
Copy link

ocavue commented Oct 13, 2022

Most packages are maintained by @marijnh, but prosemirror-tables is not. See this https://discuss.prosemirror.net/t/why-is-prosemirror-tables-not-maintained/4522/2

Porting prosemirror-tables is on my list, but I don't have ETA for it.

@PowerKiKi
Copy link

Would you accept a PR that replicate what @marijnh did for other packages, specifically leveraging @prosemirror/buildhelper ?

@ocavue
Copy link

ocavue commented Oct 13, 2022

I would appreciate a PR.

@PowerKiKi
Copy link

I would appreciate a PR.

See ProseMirror/prosemirror-tables#183 for the work in progress

@lwyj123 or @marijnh could you please close this issue, since all packages that you maintain are available as Typescript ?

@marijnh marijnh closed this as completed Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants