Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker support #48

Open
Proryanator opened this issue Oct 9, 2023 · 6 comments
Open

Docker support #48

Proryanator opened this issue Oct 9, 2023 · 6 comments
Assignees

Comments

@Proryanator
Copy link
Owner

Would be nice if both the tool itself, as well as the downloading of the source files had some docker support.

The more ways people can easily run this tool the more accessible it will be.

@e-dong
Copy link
Contributor

e-dong commented Oct 11, 2023

I do a lot of docker stuff at work, so I could potentially help with this unless you want to do it. What kind of base image did you have in mind? Most docker images are based off of Linux images. We could also compile various Linux binaries in the containers for release assets. This would be simpler than trying to set up VMs.

Do you mind clarifying on using docker to download source files?

@Proryanator
Copy link
Owner Author

Proryanator commented Oct 12, 2023

You can give it a shot! So long as you have a Windows machine to test it out on too 😊 Just that the docker container should auto download the files while it runs, so that may even just be an update to the cli tools themselves (not really docker specific).

But that way when you go to run the container that's all you need to do.

As for base images yea some linux based one would be fine, maybe a lightweight one. Ideally ffmpeg and other requirmenentd would be there, and work well with using your GPUs on Linux/Windows (i.e. docker be able to see your host GPU and use it). That may be the challenging bit but I think that's been done before.

@e-dong
Copy link
Contributor

e-dong commented Oct 12, 2023

I dual boot with windows so I can test that! Ohh gotcha, that makes sense. Maybe there should be a separate issue for auto downloading the files.

I'm familiar with Nvidia GPU, but I don't have an AMD GPU to test with. I can focus on nvidia for now.
windows: WSL2
https://www.docker.com/blog/wsl-2-gpu-support-is-here/
Linux: nvidia-docker
https://github.com/NVIDIA/nvidia-container-toolkit

Base image I was thinking of using cuda: https://hub.docker.com/r/nvidia/cuda/tags
Not sure lightweight is possible because of cuda haha

@Proryanator
Copy link
Owner Author

That sounds good to me! Go for it! I can build off what you make for Nvidia and we can round it out 👍

@mcam10
Copy link

mcam10 commented Jun 20, 2024

Anybody pick this up yet? Just found this repo cus I wanted to put my Nvidia Jetson's to the test.. but the support for Docker would be nice.

@Proryanator
Copy link
Owner Author

Anybody pick this up yet? Just found this repo cus I wanted to put my Nvidia Jetson's to the test.. but the support for Docker would be nice.

Not yet! But appreciate you sharing your interest. It has moved up in priority ;)

@Proryanator Proryanator self-assigned this Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants