Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: inventory #221

Merged
merged 3 commits into from
Dec 18, 2024
Merged

feat: inventory #221

merged 3 commits into from
Dec 18, 2024

Conversation

albert1413
Copy link
Contributor

@albert1413 albert1413 commented Dec 18, 2024

This pull request introduces significant enhancements to the Inventory.php view and some minor updates to the AdminInventoryLayout.php layout. The main changes include the addition of a filter panel, integration of GeoJSON data for displaying map features, and improved map interaction capabilities.

Enhancements to Inventory.php:

  • Filter Panel Implementation:

    • Added a button to open the filter panel and the filter panel itself with options to filter zones and elements.
    • Included JavaScript to handle the display logic for the filter panel and its buttons.
  • Map Enhancements:

    • Changed the map style to satellite-streets-v12 and updated the initial zoom and center coordinates.
    • Integrated GeoJSON data to add a polygon representing Valencia's historic center and several points of interest.
    • Added layers to display the polygon and points on the map, and implemented click events to show popups with descriptions.
    • Enhanced user interaction by changing the cursor to a pointer when hovering over the map features.

Minor Update to AdminInventoryLayout.php:

  • Layout Adjustment:
    • Added a blank line to improve code readability.

@albert1413 albert1413 requested a review from a team as a code owner December 18, 2024 16:53
@github-actions github-actions bot added kind/feature Categorizes issue or PR as related to a new feature. area/app/views Categorizes issue or PR as related to app/views. labels Dec 18, 2024
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 63 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
app/src/app/Views/Admin/Inventory.php 0.00% 63 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              main    #221      +/-   ##
==========================================
- Coverage     4.57%   4.48%   -0.10%     
  Complexity     314     314              
==========================================
  Files           95      95              
  Lines         2948    3010      +62     
==========================================
  Hits           135     135              
- Misses        2813    2875      +62     
Files with missing lines Coverage Δ Complexity Δ
app/src/app/Layouts/Admin/AdminInventoryLayout.php 0.00% <ø> (ø) 0.00 <0.00> (ø)
app/src/app/Views/Admin/Inventory.php 0.00% <0.00%> (ø) 0.00 <0.00> (ø)

@0x1026 0x1026 changed the title Feat/inventary-map feat: inventory Dec 18, 2024
@albert1413 albert1413 merged commit db0bc96 into main Dec 18, 2024
14 checks passed
@albert1413 albert1413 deleted the feat/inventary-map branch December 18, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/app/views Categorizes issue or PR as related to app/views. kind/feature Categorizes issue or PR as related to a new feature.
Projects
Status: Fet
Development

Successfully merging this pull request may close these issues.

2 participants