Added translucent background to video overlay text #699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #576 where there was difficulty reading white text on a light background. Adding a slightly opaque background makes the text easier to read.
41 tasks
|
Looks fine on my 23" at home. Will test this on my 30" in lab tomorrow. |
|
Looks fine to me. This is on my 30" in lab.
What do you think @jonfroehlich? |
|
Is this pushed to sidewalk-dev?
…On Tue, Jun 20, 2017 at 4:57 PM, Manaswi Saha ***@***.***> wrote:
Looks fine to me. This is on my 30" in lab.
[image: image]
<https://user-images.githubusercontent.com/2873216/27355563-7d668088-55d9-11e7-936b-e37c9b4f9be0.png>
What do you think @jonfroehlich <https://github.com/jonfroehlich>?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#699 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABi-9fF-JpDnSOsA62TMRgbOw34vldcHks5sGDI7gaJpZM4N-ved>
.
--
Jon Froehlich
Assistant Professor
Computer Science
University of Maryland, College Park
http://www.cs.umd.edu/~jonf/
@jonfroehlich <https://twitter.com/jonfroehlich> - Twitter
|
|
No, I was testing it on my big screen first before merging and pushing it.
On my way home. Will push it after reaching.
On Tue, Jun 20, 2017 at 5:06 PM Jon Froehlich <[email protected]>
wrote:
Is this pushed to sidewalk-dev?
On Tue, Jun 20, 2017 at 4:57 PM, Manaswi Saha ***@***.***>
wrote:
> Looks fine to me. This is on my 30" in lab.
>
> [image: image]
> <
https://user-images.githubusercontent.com/2873216/27355563-7d668088-55d9-11e7-936b-e37c9b4f9be0.png
>
>
> What do you think @jonfroehlich <https://github.com/jonfroehlich>?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <
#699 (comment)
>,
> or mute the thread
> <
https://github.com/notifications/unsubscribe-auth/ABi-9fF-JpDnSOsA62TMRgbOw34vldcHks5sGDI7gaJpZM4N-ved
>
> .
>
--
Jon Froehlich
Assistant Professor
Computer Science
University of Maryland, College Park
http://www.cs.umd.edu/~jonf/
@jonfroehlich <https://twitter.com/jonfroehlich> - Twitter
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#699 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACvXgGMeA5PFS-LCQKxW882lj0I_H-eLks5sGDRWgaJpZM4N-ved>
.
--
Manaswi Saha
PhD CS Student
University of Maryland, College Park
http://cs.umd.edu/~manaswi
…Sent from my iPhone
|
|
ok. please let me know when you do an i'll test it.
On Tue, Jun 20, 2017 at 5:08 PM, Manaswi Saha <[email protected]>
wrote:
… No, I was testing it on my big screen first before merging and pushing it.
On my way home. Will push it after reaching.
On Tue, Jun 20, 2017 at 5:06 PM Jon Froehlich ***@***.***>
wrote:
> Is this pushed to sidewalk-dev?
>
> On Tue, Jun 20, 2017 at 4:57 PM, Manaswi Saha ***@***.***>
> wrote:
>
> > Looks fine to me. This is on my 30" in lab.
> >
> > [image: image]
> > <
> https://user-images.githubusercontent.com/2873216/
27355563-7d668088-55d9-11e7-936b-e37c9b4f9be0.png
> >
> >
> > What do you think @jonfroehlich <https://github.com/jonfroehlich>?
> >
> > —
> > You are receiving this because you were mentioned.
> > Reply to this email directly, view it on GitHub
> > <
> #699#
issuecomment-309889258
> >,
> > or mute the thread
> > <
> https://github.com/notifications/unsubscribe-auth/ABi-9fF-
JpDnSOsA62TMRgbOw34vldcHks5sGDI7gaJpZM4N-ved
> >
> > .
> >
>
>
>
> --
> Jon Froehlich
> Assistant Professor
> Computer Science
> University of Maryland, College Park
> http://www.cs.umd.edu/~jonf/
> @jonfroehlich <https://twitter.com/jonfroehlich> - Twitter
>
> —
> You are receiving this because you commented.
>
>
> Reply to this email directly, view it on GitHub
> <#699#
issuecomment-309891503>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/ACvXgGMeA5PFS-
LCQKxW882lj0I_H-eLks5sGDRWgaJpZM4N-ved>
> .
>
--
Manaswi Saha
PhD CS Student
University of Maryland, College Park
http://cs.umd.edu/~manaswi
Sent from my iPhone
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#699 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABi-9auJUt2069-WjtyHhZQm2fsSpy8Oks5sGDTngaJpZM4N-ved>
.
--
Jon Froehlich
Assistant Professor
Computer Science
University of Maryland, College Park
http://www.cs.umd.edu/~jonf/
@jonfroehlich <https://twitter.com/jonfroehlich> - Twitter
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #576 where there was difficulty reading white text on a light background. Adding a slightly opaque background makes the text easier to read. This has been tested on small and medium sized monitors; still needs testing on monitors with >25" screens.