Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Something Going on With Anonymous Users? #791

Closed
jonfroehlich opened this issue Jun 30, 2017 · 12 comments
Closed

Something Going on With Anonymous Users? #791

jonfroehlich opened this issue Jun 30, 2017 · 12 comments
Assignees

Comments

@jonfroehlich
Copy link
Member

@misaugstad pointed out to me tonight that there is something strange going on with the anonymous user contributions. Notice, for example, that the top ip address audited 15 street segments but contributed 4,381 labels. This is insane!

image

So, we need to investigate. Could it be:

  • Vandalism or that some anonymous users have no idea what they are doing?
  • A bug in the Scala/SQL query returning this data
  • A bug in displaying this chart
  • Other thing?

Who wants to investigate? @r-holland @sbower213 @Adash12?

@manaswisaha
Copy link
Member

@r-holland @sbower213 @Adash12 Is anyone looking into this?

Since @sbower213 is now busy on a different issue, can one of you look into it?

@chishankar
Copy link
Collaborator

Yeah I can look into it

@chishankar
Copy link
Collaborator

From looking at it, my initial hypothesis is that the label count is just continuously adding the users label count to the overall total.

For example: 73.163.171.105 did 137 Audits and created 651 labels, but it added it to the previous total of 2020 and outputted 2671 as the total Label Count.

I will look further into this to confirm my hypothesis and fix this.

@chishankar chishankar self-assigned this Jun 30, 2017
@jonfroehlich
Copy link
Member Author

@chishankar your explanation doesn't make sense to me. :P

@chishankar
Copy link
Collaborator

I believe the user's total label count gets added to the overall total label count and that is why there is an inflation of numbers. I am looking into to it and will post a more comprehensive explanation once I know for sure what it is

@misaugstad
Copy link
Member

misaugstad commented Jun 30, 2017

After he talked to me in person, I think what he is saying is that...
If you look take the bottom user in that table, it says they have 1796 labels. But if you go up to the user that is 2nd from the bottom, they have 1886 labels with 2 audits. He is saying that this user actually has 1886-1796=90 labels in the 2 audits. So the number of labels is cumulative, going up the table.

I think that he will soon discover that this is certainly not how this is calculated :)

@misaugstad
Copy link
Member

Oh, and the above table is in the admin dashboard, in the "Users" tab, the 2nd table (the one of anonymous users). I then sorted by label count.

@sbower213 sbower213 self-assigned this Jun 30, 2017
@sbower213
Copy link
Collaborator

I think I figured it out. One of the sql subqueries was pulling a lot of duplicates, and when the number of labels from each audit were added, it would keep adding duplicates. I added a "select distinct" into the query and think I've fixed it. I'll do some more cross referencing of the table to make sure I didn't omit anything, but this is what the new table looks like:
image

@jonfroehlich
Copy link
Member Author

jonfroehlich commented Jun 30, 2017 via email

@ghost ghost added the in progress label Jun 30, 2017
@sbower213
Copy link
Collaborator

anything from localhost gets logged like that, according to stackoverflow

@jonfroehlich
Copy link
Member Author

jonfroehlich commented Jun 30, 2017 via email

@misaugstad
Copy link
Member

Resolved via #799

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants