Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility Issues #118

Closed
nickytonline opened this issue Aug 19, 2020 · 4 comments
Closed

Accessibility Issues #118

nickytonline opened this issue Aug 19, 2020 · 4 comments

Comments

@nickytonline
Copy link
Contributor

nickytonline commented Aug 19, 2020

Accessibility Issues

In the PostAJobForm.js file, the htmlFor JSX prop (rendered as for HTML attribute) should be position-type not positionType .

image

image

The .text-blue-500 CSS class’ color property does not provide enough contrast. I messed around with the WebAIM Contrast Checker tool and this seemed like a suitable colour, #55556D. that provides enough contrast and it still looks good.

image

The validation error .input-error CSS class’ color property does not provide enough contrast. I messed around with the WebAIM Contrast Checker tool and this seemed like a suitable colour, #AF1818. that provides enough contrast and it still looks good.

The <ReactQuill /> component has several accessibility issues. See slab/quill#2038 . It would probably make for a great PR that would help all using this editor support better accessibility.

@nickytonline
Copy link
Contributor Author

Note that are still other accessibility issues in the site. Take the Axe browser extension (Chrome | Firefox) for a spin to find more future contributors!

@drewclem
Copy link
Collaborator

@nickytonline Thanks for this issue! I'll definitely comb through with Axe to find our other issues and get them up

@nickytonline
Copy link
Contributor Author

There is also the WebAIM WAVE browser extension.

@drewclem
Copy link
Collaborator

Resolved with #121

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants