Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up style specific rules from ESLint configuration #42

Closed
thescientist13 opened this issue May 3, 2024 · 1 comment · Fixed by #102
Closed

clean up style specific rules from ESLint configuration #42

thescientist13 opened this issue May 3, 2024 · 1 comment · Fixed by #102
Labels
chore project maintenance related tasks good first issue Good for newcomers

Comments

@thescientist13
Copy link
Member

Summary

Coming out of #40 we just pulled in the standard ESLint configuration we've been using in most ProjectEvergreen projects, however to ensure better interop with Prettier (making sure ESLint rules and Prettier rules don't conflict) the eslint-config-prettier package was added to turn off those particular style rules from ESLint/

Details

So the idea with this task is that the following outcomes should be possible:

  1. Go through the eslint.config.js file and remove any stylistic only rules
  2. Should be able to remove the eslint-config-prettier plugin from our dependencies
  3. Test that Prettiers and ESLint rules are still working well together
@thescientist13
Copy link
Member Author

I think is resolved now as part of #43 / #102, we just adopted ESLint's recommended styles, and so we are no longer maintaining a custom list anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore project maintenance related tasks good first issue Good for newcomers
Projects
Development

Successfully merging a pull request may close this issue.

1 participant