dev server proxy is not forwarding query params

[thescientist13]

Type of Change

• New Feature Request
• Documentation / Website
• Improvement / Suggestion
• Bug
• Other (please clarify below)

Summary

Noticed that in one of my projects, if I had a URL that had query parameters, they would not be included in the outbound URL.

Details

For example, a URL like

/api/foo?query=xyz

When logged, would come out as

/api/foo

This might overlap with the solution for #578 so need to make sure both browser level URL query params and app request query params can all play nice.

[thescientist13]

Still not fixed, looks like there is a major flaw in the current logic

return Promise.resolve(fs.existsSync(this.compilation.context.userWorkspace, bareUrl) || bareUrl === '/');

It should be using path.join before checking if the file fs.exists on disk, as right now it will always be true for userWorkspace 🤦