Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade Rollup and all plugins to 3.x #1087

Closed
thescientist13 opened this issue Apr 1, 2023 · 1 comment · Fixed by #1187 or #1208
Closed

upgrade Rollup and all plugins to 3.x #1087

thescientist13 opened this issue Apr 1, 2023 · 1 comment · Fixed by #1187 or #1208
Assignees
Labels
alpha.0 CLI enhancement Improve something existing (e.g. no docs, new APIs, etc) Plugins Greenwood Plugins sponsorship:claimed sponsorship:eligible v0.30.0
Milestone

Comments

@thescientist13
Copy link
Member

thescientist13 commented Apr 1, 2023

Type of Change

Enhancement

Summary

We are a little behind on our Rollup version, in fact at the time of this writing, Rollup v3 was out, but now v4 is also out!

Big things that come with this are:

Details

We should go through the v3 docs and upgrade guide test that everything is compatible .

If that goes well, we should try and upgrade to v4. 🤞


Some notes to self :

  1. Want to call out I ran into this issue with fs/promises - [@rollup/plugin-node-resolve] error detecte if a string matches the name of a Node.js builtin module rollup/plugins#1120
  2. avoiding JSON in escodegen somehow? - require of _package.json_ complicates bundling estools/escodegen#455
    this is due to make JSX transformations (and dependencies) opt-in / lazy loaded wcc#116
  3. Per Enhancement/issue 1088 refactor Workers out of SSR builds #1110, had to add this work around for Lit, should see if it can be removed - https://github.com/ProjectEvergreen/greenwood/pull/1110/files#diff-57634df7e2b1ba3ea0031d8adc1e73230ca3c93bbecfdea7b44d00c7e100ec8bR251
@thescientist13 thescientist13 added enhancement Improve something existing (e.g. no docs, new APIs, etc) Plugins Greenwood Plugins CLI labels Apr 1, 2023
@thescientist13 thescientist13 added this to the 1.0 milestone Apr 1, 2023
@thescientist13 thescientist13 changed the title upgrade Rollup and all plugins (to v3?) upgrade Rollup and all plugins to v3 Oct 8, 2023
@thescientist13 thescientist13 changed the title upgrade Rollup and all plugins to v3 upgrade Rollup and all plugins to latest version Nov 26, 2023
@thescientist13 thescientist13 moved this from 🔖 Ready to 🏗 In progress in [Greenwood] Phase 9 - Standards and Conventions Dec 7, 2023
@thescientist13
Copy link
Member Author

So based on research I add to #923 it looks like this task will have to cap out the Rollup upgrade to 3.x

@thescientist13 thescientist13 changed the title upgrade Rollup and all plugins to latest version upgrade Rollup and all plugins to 3.x Feb 16, 2024
@thescientist13 thescientist13 moved this from 🏗 In progress to 👀 In review in [Greenwood] Phase 9 - Standards and Conventions Feb 16, 2024
@thescientist13 thescientist13 mentioned this issue Mar 9, 2024
39 tasks
@thescientist13 thescientist13 linked a pull request Mar 9, 2024 that will close this issue
39 tasks
@thescientist13 thescientist13 moved this from 👀 In review to ✅ Done in [Greenwood] Phase 9 - Standards and Conventions Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alpha.0 CLI enhancement Improve something existing (e.g. no docs, new APIs, etc) Plugins Greenwood Plugins sponsorship:claimed sponsorship:eligible v0.30.0
Projects
No open projects
2 participants