Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert property id to string #259

Merged
merged 1 commit into from
Nov 3, 2024
Merged

Conversation

Jerrys-C
Copy link
Contributor

@Jerrys-C Jerrys-C commented Nov 3, 2024

Overview

Fix #258
This change restores the conversion of id to a string in the RegisterProperty function. The conversion was previously removed, but this update reintroduces it to prevent potential issues with property identifier handling

Details

Converting id to a string ensures consistent and reliable usage of property IDs within PropertiesTable and propertyData. This reversion addresses problems introduced by the previous removal of this conversion

Testing Steps

Provide a list of repro steps on how to test that your changes are valid.

  • Did you test the changes you made?
  • Did you test core functionality of the script to ensure your changes do not regress other areas?
  • Did you test your changes in multiplayer to ensure it works correctly on all clients?

This change restores the conversion of id to a string in the RegisterProperty function. The conversion was previously removed, but this update reintroduces it to prevent potential issues with property identifier handling
@alp1x
Copy link
Contributor

alp1x commented Nov 3, 2024

I tried it too, this works well and seems to have solved the error, good analysis Jerry

@darktrovx darktrovx merged commit c984e7d into Project-Sloth:main Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Property.Get(id) returns nil, causing failure to locate existing property ID
3 participants