Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Added back the possibility to use skipSelection in qb-multicharacter #201

Merged
merged 3 commits into from
Apr 1, 2024

Conversation

MonsieurBibo
Copy link
Contributor

Overview

Added back the possibility to skip the spawns selection, as it was broken by the changes, as it was noted in #193. Big thanks to @Sanriku-Gaming who made me able to check the code.

Details

  • Added in the installation guide a new step, which is editing qb-multicharacter:client:spawnLastLocation event handler
  • Edited the installation guide concerning the qb-multicharacter:server:loadUserData event handler
  • Edited the dependencies part in the installation guide in order to inform that ox_lib must be run before qb-multicharacter

UI Changes / Functionality

You can now use again skipSelection in qb-multicharacter.

Testing Steps

  • Follow the new installation guide
  • Be sure that skipSelection is set to false in qb-multicharacter
  • Start your server
  • You can choose your spawn
  • Repeat the process with skipSelection is set to true in qb-multicharacter
  • You automatically spawn back at the last location.

  • Did you test the changes you made?
  • Did you test core functionality of the script to ensure your changes do not regress other areas?
  • Did you test your changes in multiplayer to ensure it works correctly on all clients?

Copy link
Member

@MonkeyWhisper MonkeyWhisper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Request changes.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@MonsieurBibo
Copy link
Contributor Author

Should be good now !

README.md Outdated Show resolved Hide resolved
@MonsieurBibo
Copy link
Contributor Author

Hopefully everything is good now !

@MonkeyWhisper MonkeyWhisper merged commit 55f4d2a into Project-Sloth:main Apr 1, 2024
@MonsieurBibo MonsieurBibo deleted the dev branch April 1, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants